Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export WASM binding TS types #754

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Export WASM binding TS types #754

merged 3 commits into from
Jun 28, 2024

Conversation

arobsn
Copy link
Member

@arobsn arobsn commented Jun 21, 2024

This fixes issues with modern module resolution strategies

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9614524833

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 80.502%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/serialization/types.rs 4 83.28%
Totals Coverage Status
Change from base Build 9427239808: 0.1%
Covered Lines: 10751
Relevant Lines: 13355
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9614651139

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 80.457%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/serialization/types.rs 8 81.18%
Totals Coverage Status
Change from base Build 9427239808: 0.08%
Covered Lines: 10745
Relevant Lines: 13355
💛 - Coveralls

@arobsn arobsn requested review from kushti and SethDusek June 26, 2024 13:28
@SethDusek
Copy link
Collaborator

Hi, please rebase. JS test failures are fixed now.

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9716209928

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 80.472%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/serialization/types.rs 8 81.88%
Totals Coverage Status
Change from base Build 9698774861: -0.02%
Covered Lines: 10747
Relevant Lines: 13355
💛 - Coveralls

@SethDusek SethDusek merged commit 519ec21 into ergoplatform:develop Jun 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethDusek SethDusek SethDusek approved these changes

@kushti kushti Awaiting requested review from kushti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arobsn @coveralls @SethDusek